Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Favored terrain and other references to (premaster) Wild Stride #18084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dotadd
Copy link
Contributor

@dotadd dotadd commented Jan 23, 2025

Closes #16961

  • Replace reference to (old) Wild Stride with Unimpeded Journey

Also:

  • Add missing movement bonus effects to Favored Terrain
  • Adjust these effects to remaster

@TikaelSol
Copy link
Collaborator

These are automatable now, so we should actually mothball the effects and probably move the automation to the feature itself.

@dotadd
Copy link
Contributor Author

dotadd commented Jan 24, 2025

That sounds like a good idea. I'm just not clear on some of the details:

  1. The terrain type should probably be a drop-down, because of things like Terrain Master being able to change it short-term, right? And a choice set would require removing and re-adding the feature.
  2. How would we detect whether the actor is in that terrain? Just with toggle or anything more elaborate like regions?
  3. Is ignoring difficult terrain from regions possibility?
  4. I'm not sure how I would go about any part of this tbh: Arctic: You need to eat and drink only one-tenth as much as usual, you aren’t affected by severe or extreme cold, and you can walk across ice and snow at full Speed without needing to Balance.

@TikaelSol
Copy link
Collaborator

Sorry, been away from merging for a bit.

1: We can do a drop down with terrain master to do the swap out, but we shouldn't make the initial choice a toggle like that. Basically a choice set and a separate roll option to set the terrain, predicate the roll option on not having terrain master. Then terrain master can have suboptions.

2: It would be with regions. terrain:x as the roll option already works.

3: Not currently. We need to figure out how we are going to handle difficult terrain in the system itself, which is waiting for some stuff in v13.

4: We wouldn't automate any of that

@dotadd
Copy link
Contributor Author

dotadd commented Feb 5, 2025

Thanks for the clarifications!

I'm on it, but running into an issue. I have to predicate the speeds on whether the actor already has the relevant speed type or not. So for example ["speed:swim"] applied to a FlatModifier or a BaseSpeed respectively, but that doesn't seem to work. Here's the most simplified version of one such RE:

{
  "key": "FlatModifier",
  "selector": "swim-speed",
  "type": "status",
  "value": 10,
  "predicate": [
    "speed:swim"
  ]
}

Applied to an actor with a swim speed I set to 5 beforehand. And it just doesn't take effect. Nothing on the log either. Any idea what I'm missing here? How would I investigate this further? I'm not sure how I would "debug" this.

@pedrogrullada pedrogrullada added the pr: data update Updates to existing actors and items label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement of Wild Stride by Unimpeded Journey
3 participants